Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Add explicit interface support #1058

Merged
merged 13 commits into from
Jan 27, 2025
Merged

FIX: Add explicit interface support #1058

merged 13 commits into from
Jan 27, 2025

Conversation

dipinknair
Copy link
Collaborator

Fixes #639

Users can now get Ids of NamedSelection as give below

ids = list(Model.NamedSelections.Children[0].Ids)
print(ids)
[365, 432]

or

ids = Model.NamedSelections.Children[0].Ids
print(ids[0])
365

@dipinknair dipinknair marked this pull request as ready for review January 22, 2025 21:05
@dipinknair dipinknair requested a review from a team as a code owner January 22, 2025 21:05
@github-actions github-actions bot added the bug Something isn't working label Jan 22, 2025
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 22, 2025
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.63%. Comparing base (868afe8) to head (b513791).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1058      +/-   ##
==========================================
- Coverage   87.64%   87.63%   -0.02%     
==========================================
  Files          36       36              
  Lines        2348     2362      +14     
==========================================
+ Hits         2058     2070      +12     
- Misses        290      292       +2     

@dipinknair dipinknair requested a review from koubaa January 23, 2025 19:24
tests/embedding/test_app.py Outdated Show resolved Hide resolved
@dipinknair dipinknair requested a review from koubaa January 27, 2025 17:16
@dipinknair dipinknair merged commit 95959cc into main Jan 27, 2025
58 checks passed
@dipinknair dipinknair deleted the fix/attributes branch January 27, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug : PyMechanical is not able display inherited attributes
3 participants